Remove llamafactory and verl resources req and limit #174
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the CPU and memory resource requirements and limits from the llamafactory and verl Kubernetes configurations, commenting them out while keeping the GPU resource specifications intact.
- Commented out CPU and memory resource limits and requests for both configurations
- Retained nvidia.com/gpu resource specifications unchanged
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| incubator/verl-on-tke/values.yaml | Commented out CPU and memory resource limits/requests |
| incubator/llama-factory-on-tke/values.yaml | Commented out CPU and memory resource limits/requests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # cpu: "" | ||
| # memory: "" | ||
| nvidia.com/gpu: "1" | ||
| requests: | ||
| cpu: "20" | ||
| memory: 400Gi | ||
| # cpu: "" | ||
| # memory: "" |
There was a problem hiding this comment.
The commented CPU and memory resource specifications contain empty strings. Consider removing these empty values or providing placeholder examples like '# cpu: "40"' to maintain clarity about expected format.
| # cpu: "" | ||
| # memory: "" | ||
| nvidia.com/gpu: "1" | ||
| requests: | ||
| cpu: "20" | ||
| memory: 400Gi | ||
| # cpu: "" | ||
| # memory: "" |
There was a problem hiding this comment.
The commented CPU and memory resource specifications contain empty strings. Consider removing these empty values or providing placeholder examples like '# cpu: "40"' to maintain clarity about expected format.
|
lgtm |
2 participants
No description provided.